fix: remove bezoekadres/verblijfadres from role matching between ZDS and ZGW due to situational dataloss in translation #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLenterman
approved these changes
Dec 6, 2024
MLenterman
changed the title
WeAreFrank-BOT
pushed a commit
that referenced
this pull request
Dec 6, 2024
## [1.22.6](v1.22.5...v1.22.6) (2024-12-06) ### 🐛 Bug Fixes * remove bezoekadres/verblijfadres from role matching between ZDS and ZGW due to situational dataloss in translation ([#478](#478)) ([38a59bd](38a59bd)) ### ✅ Tests * **larva:** cleanup old broken Larva testcases that are now replaced by SoapUI end-2-end testcases ([#480](#480)) ([0749015](0749015))
|
🎉 This PR is included in version 1.22.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
MLenterman
added a commit
that referenced
this pull request
Dec 17, 2024
…and ZGW due to situational dataloss in translation (#478) * fix: update the comparison of the roles for different person * dummy commit to trigger ci * syntax fixed --------- Co-authored-by: Meric Akgul <[email protected]> Co-authored-by: MLenterman <[email protected]>
MLenterman
pushed a commit
that referenced
this pull request
Dec 17, 2024
## [1.22.6](v1.22.5...v1.22.6) (2024-12-06) ### 🐛 Bug Fixes * remove bezoekadres/verblijfadres from role matching between ZDS and ZGW due to situational dataloss in translation ([#478](#478)) ([38a59bd](38a59bd)) ### ✅ Tests * **larva:** cleanup old broken Larva testcases that are now replaced by SoapUI end-2-end testcases ([#480](#480)) ([0749015](0749015))
WeAreFrank-BOT
pushed a commit
that referenced
this pull request
Dec 17, 2024
## [1.22.7](v1.22.6...v1.22.7) (2024-12-17) ### 🐛 Bug Fixes * heeftBetrekkingOpAndere does not respect verwerkingssoort causing duplicates and inability to delete gerelateerde zaken ([7243e0f](7243e0f)) * remove bezoekadres/verblijfadres from role matching between ZDS and ZGW due to situational dataloss in translation ([#478](#478)) ([98a24c4](98a24c4)) * remove relevanteAndereZaken from updateZaak request cause it is handled separately ([90c51b0](90c51b0)) * update verwerkingssoort letter of heeftBetrekkingOpAndere in creeerZaak from W to T ([8a849c1](8a849c1)) * updateZaak with multiple heeftBetrekkingOpAndere already on the case results in error ([663516b](663516b)) ### 🧑💻 Code Refactoring * generalize ZDS roles was and wordt merger xslt to support merging all root aggregates ([2131767](2131767)) * Used PostZgwZaak.xsd instead of AndereZaakBodyToJson.xsd + used XmlSwitchPipe instead of XmlIfPipe in CheckVerwerkingssoortAttribute + used Zaken_UpdateZgwZaak for patch request ([017bfd9](017bfd9)) ### ✅ Tests * **e2e:** add variety of e2e testcases for testing heeftBetrekkingOpAndere behavior ([757f127](757f127)) * **larva:** cleanup old broken Larva testcases that are now replaced by SoapUI end-2-end testcases ([#480](#480)) ([934e839](934e839)) * **unit:** MergeZdsWasAndWordt Larva testcases ([6bf6159](6bf6159))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there is a new role coming from zds side, we first check if that role already exists in zgw. To do that we compare the incoming role with existing roles. Our comparison were returning incorrectly false value so we were trying to add the same initiator rol again and OpenZaak were giving us an error. Now we have update our comparison method to fix the issue.